Definition of Done - WHAT 

Definition of Done  - HOW 

• PBI / Bug fixes meet all Acceptance Criteria  

• PBI : Conforms to the user story set out by PO/ UX 

• Bug : Conforms to expected behaviour set out by PO/ UX 

• Code is peer reviewed by 1 people (2 person as needed to be determined by team) and approved via pull request process. 

• Tag on Devops (@all devs) and message (@all devs) on MS Teams (Dev chat) channel to review 

• Person who wrote code will follow up if not reviewed 

• Pull requests are currently captured in Repos 

• Code is tested before & after the pull request. 

• All automated testing / unit testing passes (if available and needed).  

• Perform required functional  testing if necessary 

• Create unit test as required 

• Add notes if testing cannot be performed 

• Run test locally to reduce impact on other code (If failed, fix before pull request) 

• Use Azure Devops automation pipeline functionality  

• Functional testing are captured within ‘in progress’ column 

  • Functional testing is completed when dev runs program locally  

• Unit testing – run through task on ADO pipeline to ensure it meets expected behaviours and functions  

• Work should be aligned to WCAG2.1 Level AA Standard. 

WCAG verifier (WAVE) is currently used by developers. 

• Additional materials such as Home - The A11Y Project; Checklist - The A11Y Project will be used.  

• Web Content Accessibility Guidelines (WCAG) 2.1 (w3.org) 

• How to Meet WCAG (Quickref Reference) (w3.org) 

• All tasks associated with the PBI / Bug are set to DONE DONE

• The person / people who complete the task who performs functional testing should set it PBI to done  

• The last person who finishes integration (ie. code is merged into ACC) should be responsible to set story (pbi) / bug as done.  

• Attach relevant documents to PBI / Bug (ie. scripts, certificate pdf templates, etc.) 

• Attach relevant documentations to PBI 

• Built-in text (UI elements) of the application will be localized to English and French. (Exceptions will be handled on case by case basis) 

• English text will provided with user story (provided by Troy)  and added to resource file 

• Devs ask for assistance French translation (Karen, Troy)  and add it to resource file  

• UX provides input on text layout in EN/ FR in Figma  

• Secure coding standards and best practices are followed (e.g. KeyVault, password security, no protected B info) 

• Don't add sensitive information (password, user id into our code)  

• Guidelines to follow  

  • Guideline on Service and Digital (overarching) 

  • Annex C: Guidelines for safeguarding information and assets 

  • Government of Canada Digital Standards - Canada.ca