TK - Definition of Done (DoD)

Owned by Justin Green (Unlicensed)
Last updated: Mar 27, 2023 by Maggie.Lee (Unlicensed)
3 min read

Team Kraken’s Definition of Done (updated: Mar 13, 2023)

Definition of Done (DoD) is an agreed upon list of items that must be completed before PBI can be considered complete. The PBI is either done or not done – there is no 80% or “almost” done.

It is an agreed upon list to build a quality Product Increment by the end of sprint.

 

Revised DoD as of Mar 13, 2023

Definition of Done - WHAT 

Definition of Done  - HOW 

  • PBI / Bug fixes meet all Acceptance Criteria  

  • PBI : Conforms to the user story set out by PO/ UX 

  • Bug : Conforms to expected behaviour set out by PO/ UX 

  • Code is peer reviewed by 1 people (2 person as needed to be determined by team) and approved via pull request process. 

  • Tag on Devops (@all devs) and message (@all devs) on MS Teams (Dev chat) channel to review 

  • Person who wrote code will follow up if not reviewed 

  • Pull requests are currently captured in Repos 

 

  • Code is tested before & after the pull request. 

  • All automated testing / unit testing passes (if available and needed).  

  • Perform required functional  testing if necessary 

  • Create unit test as required 

  • Add notes if testing cannot be performed 

  • Run test locally to reduce impact on other code (If failed, fix before pull request) 

  • Use Azure Devops automation pipeline functionality  

  • Functional testing are captured within ‘in progress’ column 

    • Functional testing is completed when dev runs program locally  

  • Unit testing – run through task on ADO pipeline to ensure it meets expected behaviours and functions  

 

  • Work should be aligned to WCAG2.1 Level AA Standard. 

WCAG verifier (WAVE) is currently used by developers. 

  • All tasks associated with the PBI / Bug are set to DONE

  • The person who performs functional testing should set PBI to done. 

  • Attach relevant documents to PBI / Bug (ie. scripts, certificate pdf templates, etc.) 

  • Attach relevant documentations to PBI 

 

  • Built-in text (UI elements) of the application will be localized to English and French. (Exceptions will be handled on case by case basis) 

  • English text will provided with user story (provided by Troy)  and added to resource file 

  • Devs ask for assistance French translation (Karen, Troy)  and add it to resource file  

  • UX provides input on text layout in EN/ FR in Figma  

 

  • Secure coding standards and best practices are followed (e.g. KeyVault, password security, no protected B info) 

On Mar 13, 2023 we revisited DOD and below are the key decisions/ next steps

Decisions/ Key Takeaways

  • We are getting rid of Acc Ready column 

  • Merging into acceptance is not part of the ‘definition of done’

  • The person who completes functional testing sets PBI as done (usually/ historically this person is Troy)

  • Done = coding is completed and functional testing is done 

To be discussed 

  • unit testing and how it fits in our development process/ DOD

Revised DoD as of Jun 29, 2022

These are the conditions which must be met within a Sprint for a PBI/Story to be considered done so the PBI/Story can be closed:

  • PBI / Bug fixes meet all Acceptance Criteria

  • Code is peer reviewed by 2 people (min 1 person) and approved via pull request process.

  • Code is tested before and after the pull request.

    • All automated testing / unit testing passes (if available and needed).

    • Perform required functional / load/ regression testing if necessary

    • Create unit test as required

    • Add notes if testing cannot be performed

  • Work should be aligned to WCAG2.1 Level AA Standard.

  • All tasks associated with the PBI / Bug are set to DONE

  • Attach relevant documents to PBI / Bug (ie. scripts, certificate pdf templates, etc.)

  • Built-in text (UI elements) of the application will be localized to English and French. (Exceptions will be handled on case by case basis)

  • Secure coding standards and best practices are followed (e.g. KeyVault, password security, no protected B info)

 

OLD DoD - No longer valid

Nov 10th 2021 - this version was reviewed and updated to reflect TK’s goal for smaller and frequent releases.

 

 

OLD DoD - No longer valid