Work Items
- Tsizis, Mark (TC TC)
- 1 291404
- 2 29755
- 3 29761
- 4 254537
- 5 254454
- 6 254452
- 7 231243 TC Mailer
- 8 248536
- 9 245729 and 266747
- 10 210110
- 11 Attachments
291404
Trigger Send verification code: Add External user
Trigger Send Report Status Update Email: Start new report or Finish existing report
MailKit
https://github.com/jstedfast/MailKit#using-mailkit
29755
29755 Master Report Preview all annual reports and fuel consumption in a single Report Excel doc
29755_Master_Report_Preview_all_annual_reports_and_fuel_consumption_in_a_single_Report_Excel_doc
Data:
123TrainLongName - Annual Report 2024 - Ultra-low sulphur diesel (ULSD) 123456
123TrainLongName - Annual Report 2023: (orgId=176, reportId=215)
Freight Natural Gas 13
Freight Low-sulphur diesel (LSD) 12
Commuter Low-sulphur diesel (LSD) 11
MarkCompany - Annual Report 2023: (orgId=136, reportId=207)
Freight Natural Gas 14L
Passenger Ultra-low sulphur diesel (ULSD) 12L
Commuter Low-sulphur diesel (LSD) 13L242783 NLB Link redirect to the wrong page-Jul19
Org | Year | Kind | Rec | Cert |
|---|---|---|---|---|
CN | 2022 | Year-Prepopulated-Required | 2268 |
|
CN | 2021 | Year-Preview-Completed | 2401 |
|
CPR | 2022 | N/A |
|
|
CPR | 2021 | Year-Preview-Completed | 1412 |
|
CMQ | 2022 | Year-Preview-Completed | 38 |
|
CN+CPR | 2021 | Company Reports | 2401+1409 = 3810 | CN-ULSD=1504972000 CPR-ULSD=886600074 CPR-ULSD=72584 |
29761
254537
254537 Fuel consumption decimal on the certify page, new error message when comas and points are used in the wrong language
On the Certify page, the fuel consumption usage of a decimal should be a point in English and Coma in French as it is right now.
An error new message should be prompt when a coma or point is used in the wrong language.
English error message when a coma is used for the decimals:
Sorry, a number of errors have occurred on this page.
Please enter a value for Fleet Annual Fuel Consumption.
Please use a point (.) for decimals
French error message when a point is used for decimal:
Désolé! Un certain nombre d’erreurs se sont produites sur cette page.
Veuillez entrer une valeur pour la consommation annuelle de carburant du parc de locomotives.
Veuillez utilisé la virgule (,) pour les décimals.
select count(*) from YR016_XREF_LOCOMT_FUEL_TYPE;
19691
select ANNUAL_FUEL_CONSUMPTION_NBR from YR016_XREF_LOCOMT_FUEL_TYPE WHERE ANNUAL_FUEL_CONSUMPTION_NBR LIKE '%.%' order by ANNUAL_FUEL_CONSUMPTION_NBR ;
568 rows selected
SELECT * FROM YR012_XREF_RAILWAY_FUEL_TYPE WHERE YR014_REPORT_ID = 207
SELECT ANNUAL_FUEL_CONSUMPTION_NBR FROM YR012_XREF_RAILWAY_FUEL_TYPE WHERE YR014_REPORT_ID = 207
SELECT * FROM YR016_XREF_LOCOMT_FUEL_TYPE WHERE YR003_REPORT_ID = 207;
SELECT * FROM YR012_XREF_RAILWAY_FUEL_TYPE WHERE YR014_REPORT_ID = 207;
https://dev.azure.com/transport-canada/DSD-RAIL-LEIS/_git/DSD-RAIL-LEIS/pullrequest/31878
254454
254454 Edit on User Detail page (Email) cause a crash 500 when saved
On the Users section / User details page, the Edit User Details mailing address causes an error 500 when saved.
Go to Users
Select a user
click edit for the Email.
Modify the information and click save.
Causes error 500 (see attached)
254452
254452 Edit on User Detail page (Mailing address) cause a crash 500 when saved
On the Users section/User details page, the Edit User Details mailing address causes an error 500 when saved.
Go to Users
Select a user
click edit for the Mailing address.
Modify the information and click save.
Causes error 500 (see attached)
Exception:
System.InvalidOperationException: 'There is no ViewData item of type 'IEnumerable<SelectListItem>' that has the key 'StreetNumberSuffix'.'
https://dev.azure.com/transport-canada/DSD-RAIL-LEIS/_git/DSD-RAIL-LEIS/pullrequest/31600
231243 TC Mailer
231243 Prod - Adding external user crash
On Internal Security https://eig.tc.gc.ca/leisa-asiel, (https://eigdev.tc.gc.ca/leis-siel) when we try to add an external
URLs:
How-to Install TC Mailer 3.0 on Your Machine - Marine - Confluence (atlassian.net)
Create External User: Using external email in dev env
{"5.7.54 SMTP; Unable to relay recipient in non-accepted domain"}
- ex {"5.7.54 SMTP; Unable to relay recipient in non-accepted domain"} System.Exception {MailKit.Net.Smtp.SmtpCommandException}
+ Data {System.Collections.ListDictionaryInternal} System.Collections.IDictionary {System.Collections.ListDictionaryInternal}
ErrorCode RecipientNotAccepted MailKit.Net.Smtp.SmtpErrorCode
HResult -2146233088 int
HelpLink "https://github.com/jstedfast/MailKit/blob/master/FAQ.md#ProtocolLog" string
+ InnerException null System.Exception
+ Mailbox {"tsizism@gmail.com" <tsizism@gmail.com>} MimeKit.MailboxAddress
Message "5.7.54 SMTP; Unable to relay recipient in non-accepted domain" string
Source "MailKit" string
StackTrace " at MailKit.Net.Smtp.SmtpClient.Send(FormatOptions options, MimeMessage message, MailboxAddress sender, IList`1 recipients, CancellationToken cancellationToken, ITransferProgress progress)\r\n at MailKit.Net.Smtp.SmtpClient.Send(FormatOptions options, MimeMessage message, CancellationToken cancellationToken, ITransferProgress progress)\r\n at MailKit.MailTransport.Send(MimeMessage message, CancellationToken cancellationToken, ITransferProgress progress)\r\n at LEIS.Security.Web.Providers.VerificationMailer.SendVerificationEmailViaViaMailKit(String email) in C:\\github\\DSD-RAIL-LEIS\\315887\\DSD-RAIL-LEIS\\Development\\LEIS.Security.Web\\Providers\\VerificationMailer.cs:line 41" string
StatusCode MailboxUnavailable MailKit.Net.Smtp.SmtpStatusCode
+ TargetSite {System.String Send(MimeKit.FormatOptions, MimeKit.MimeMessage, MimeKit.MailboxAddress, System.Collections.Generic.IList`1[MimeKit.MailboxAddress], System.Threading.CancellationToken, MailKit.ITransferProgress)} System.Reflection.MethodBase {System.Reflection.RuntimeMethodInfo}
https://dev.azure.com/transport-canada/DSD-RAIL-LEIS/_git/DSD-RAIL-LEIS/pullrequest/31347
App | Reference | TCMailer.ini | Service Reference | Usage | Deployment |
|---|---|---|---|---|---|
LEIS.Business | .\LEIS.Business\ Support\TC Mailer 3.0.dll | .\LEIS.Business\ Support\TCMailer.ini | N/A | N/A | Internal Business: \\ncrws548\TPwwwroot\eigdev\leis.Business.Server.Installer\Release |
LEIS.Business.Web | .\LEIS.Security\ Support\TC Mailer 3.0.dll | N/A | \LEIS.Business.Web\Service References\TCMailerWS\ | .\LEIS.Business.Web\Providers\ ReportStatusProvider.cs:: SendReportStatusNotification(…) .\LEIS.Business.Web\Providers\ReportStatusProvider.cs:: TCMailer.SmtpClient client = new TCMailer.SmtpClient(); client.Send();
| \\ncrws548\TPwwwroot\eigdev\leis-siel\bin\TC Mailer 3.0.dll |
LEIS.Security | .\LEIS.Security\Support\TC Mailer 3.0.dll | .\LEIS.Security\Support\TCMailer.ini | .\LEIS.Security\Service References\TCMailerWS\ | (called from LEIS.Security.Web) .\LEIS.Security\Messaging\VerificationMailer.cs:: SendVerificationEmail(…) TCMailer.SmtpClient client = new TCMailer.SmtpClient(); … client.Send(); | Internal Security: \\ncrws548\TPwwwroot\eigdev\LEIS.Security.Server.Installer\Release\LEIS.Security.Server.Internal.Installer.msi
Bin folder content : TBD
|
LEIS.Security.Web | \LEIS.Business\Support\TC Mailer 3.0.dll | N/A | N/A | .\LEIS.Security.Web\Controllers\ProfileController.cs:: viewModel.EmailVerificationCode = _securityProvider.SendEmailVerificationCode(viewModel.User.Email); .\LEIS.Security.Web\Controllers\UsersController.cs:: viewModel.EmailVerificationCode = _securityProvider.SendEmailVerificationCode(viewModel.User.Email); .\LEIS.Security\Messaging\VerificationMailer.cs:: TCMailer.SmtpClient client = new TCMailer.SmtpClient(); client.Send();
| \\ncrws548\TPwwwroot\eigdev\leisa-asiel\bin\TC Mailer 3.0.dll |
248536
248536 Display the Locomotive ID number on the In-use test results pages after it is submitted. (view test result)
The creation of external user in Prod and ACC is crashing.
https://eig.tc.gc.ca/leisa-asiel
https://dev.azure.com/transport-canada/DSD-RAIL-LEIS/_git/DSD-RAIL-LEIS/pullrequest/31171
245729 and 266747
245729 Edit on User Details page causes a crash 500 when saved
On the Users section / User details page, the Edit Contact Information (phone number) and Edit Emails causes an error 500 when saved.
The exception is
{"An item with the same key has already been added."}
Some more info:
https://stackoverflow.com/questions/5648060/an-item-with-the-same-key-has-already-been-added
To Fix:
Add the following to ‘<form method="post" …’ : @Html.HiddenFor(m => m.User, new { Value = "" })
Add properties edited in the View to View’s model
Adjust controller’s Get and Post methods
245729
https://dev.azure.com/transport-canada/DSD-RAIL-LEIS/_git/DSD-RAIL-LEIS/pullrequest/31079
266747
https://dev.azure.com/transport-canada/DSD-RAIL-LEIS/_git/DSD-RAIL-LEIS/pullrequest/33586
Stack Example
210110
210110 Decimals are not retained in the French spreadsheet (,.)
https://dev.azure.com/transport-canada/DSD-RAIL-LEIS/_git/DSD-RAIL-LEIS/pullrequest/29930
Decimals entered in the French spreadsheet are not retained. i.e., 0,01 or 0.01 becomes 1. This was witnessed in Dev but also in Prod. This behavior is only in the French section of LEIS
https://tcmarin.atlassian.net/wiki/spaces/RAIL/pages/2791047169/Excel+Data+Types
User Guide for Decimals
In order to support French spreadsheets within English version of Windows (and Excel) LEIS needs to be able to handle decimal separator seamless. In general, for the English locale widely used combination is period (.) as a decimal separator and comma (,) as a 1000 separator, whether for the French – is comma as the decimal separator and period as the 1000 separator. This combination is set in the Windows Language settings. LEIS provides support for decimal numbers in both languages correspondingly - period for English and comma for French versions of Excel spreadsheets. To achieve this, LEIS using the Text Cell Format for decimal numbers in its spreadsheets. At the same time, LEIS making necessary transformations in the application software. There is one limitation – neither comma nor period could be used as the 1000 separator.
https://dev.azure.com/transport-canada/DSD-RAIL-LEIS/_git/DSD-RAIL-LEIS/pullrequest/31337
https://dev.azure.com/transport-canada/DSD-RAIL-LEIS/_git/DSD-RAIL-LEIS/pullrequest/29930
