EDIT ASIS Reports
Purpose:
to enable the business client to edit ASIS initiated reports.
refer to: 199961 Edit buttons missing in MOTA reports for some functions
The current code base only allows the business to edit manually initiated reports.
Changes made:
Pull request https://dev.azure.com/transport-canada/DSD-CIVAV%20Support/_git/NORMS/pullrequest/25485
Removed the if (manual) statements from Investigation_Report.aspx → this was preventing ASIS initiated reports from being edited.
Removed the if (isManual) statement from GroundInjuries.ascx → this was preventing ASIS initiated reports from being edited.
Removed code “10” from the list of forbidden codes in ActionView.ascx.cs → this was necessary so that users would not get an error message when pressing the “Edit” button for Location and Ground Injuries.
It resolves the issues in the following subtasks:
https://dev.azure.com/transport-canada/DSD-CIVAV%20Support/_boards/board/t/DSD-CIVAV%20Support%20Team/Backlog%20items/?workitem=206443
https://dev.azure.com/transport-canada/DSD-CIVAV%20Support/_boards/board/t/DSD-CIVAV%20Support%20Team/Backlog%20items/?workitem=206494
https://dev.azure.com/transport-canada/DSD-CIVAV%20Support/_boards/board/t/DSD-CIVAV%20Support%20Team/Backlog%20items/?workitem=206515
https://dev.azure.com/transport-canada/DSD-CIVAV%20Support/_boards/board/t/DSD-CIVAV%20Support%20Team/Backlog%20items/?workitem=206517
On October 12, I created a subsequent PR, removed lines of code that I had previously disabled, by commenting them out, to make it easier to maintain the code later. This is a non-functional change. It has been tested on local and deployed to development.
https://dev.azure.com/transport-canada/DSD-CIVAV%20Support/_git/NORMS/pullrequest/25561
Acceptance:
The changes in Pull Request https://dev.azure.com/transport-canada/DSD-CIVAV%20Support/_git/NORMS/pullrequest/25485 are deployed to acceptance.
Pull Request https://dev.azure.com/transport-canada/DSD-CIVAV%20Support/_git/NORMS/pullrequest/25561 is a non-functional change and is not deployed to acceptance (it is deployed to Acc,
Dean Ciaschini is testing on acceptance, will let us know if further code changes are required.